Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[BUG] Masks not handled properly in cube spectral extraction #3312

Closed
rosteen opened this issue Nov 22, 2024 · 0 comments · Fixed by #3319
Closed

[BUG] Masks not handled properly in cube spectral extraction #3312

rosteen opened this issue Nov 22, 2024 · 0 comments · Fixed by #3319
Labels
bug Something isn't working cubeviz
Milestone

Comments

@rosteen
Copy link
Collaborator

rosteen commented Nov 22, 2024

Jdaviz component

Cubeviz

Description

While fixing #3307 I realized that we're not handling masks correctly at the moment for cubes. When we load a data cube, if it has a mask attribute that gets split out into a separate mask cube. Currently, that input mask is not being respected when we do a spectral extraction on the flux cube, leading to potentially incorrect extraction results and buggy behavior downstream when trying to, e.g., fit a model to the extracted spectrum. We need to handle input masks properly and apply them to both the flux and uncertainty cubes when extracting.

How to Reproduce

Load a MaNGA cube, attempt to fit a model to the full cube extracted spectrum, see that it fails (because all uncertainties are non-finite).

Expected behavior

No response

Browser

No response

Jupyter

No response

Software versions

No response

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working cubeviz
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant