From f67d5d1e97a79127a8f48d625bcde20625ad454d Mon Sep 17 00:00:00 2001
From: Ricky O'Steen <rosteen@stsci.edu>
Date: Wed, 24 Apr 2024 12:08:19 -0400
Subject: [PATCH 1/2] Fix behavior before any lines are loaded

---
 jdaviz/configs/specviz/plugins/line_analysis/line_analysis.py  | 2 +-
 jdaviz/configs/specviz/plugins/line_analysis/line_analysis.vue | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/jdaviz/configs/specviz/plugins/line_analysis/line_analysis.py b/jdaviz/configs/specviz/plugins/line_analysis/line_analysis.py
index 6e7b1f841b..b6e5f06479 100644
--- a/jdaviz/configs/specviz/plugins/line_analysis/line_analysis.py
+++ b/jdaviz/configs/specviz/plugins/line_analysis/line_analysis.py
@@ -102,7 +102,7 @@ class LineAnalysis(PluginTemplateMixin, DatasetSelectMixin, SpectralSubsetSelect
     results_computing = Bool(False).tag(sync=True)
     results = List().tag(sync=True)
     results_centroid = Float().tag(sync=True)  # stored in AA units
-    line_menu_items = List([{}]).tag(sync=True)
+    line_menu_items = List([]).tag(sync=True)
     sync_identify = Bool(True).tag(sync=True)
     sync_identify_icon_enabled = Unicode(read_icon(os.path.join(ICON_DIR, 'line_select.svg'), 'svg+xml')).tag(sync=True)  # noqa
     sync_identify_icon_disabled = Unicode(read_icon(os.path.join(ICON_DIR, 'line_select_disabled.svg'), 'svg+xml')).tag(sync=True)  # noqa
diff --git a/jdaviz/configs/specviz/plugins/line_analysis/line_analysis.vue b/jdaviz/configs/specviz/plugins/line_analysis/line_analysis.vue
index 83e0d2495d..2cdbb5cae4 100644
--- a/jdaviz/configs/specviz/plugins/line_analysis/line_analysis.vue
+++ b/jdaviz/configs/specviz/plugins/line_analysis/line_analysis.vue
@@ -137,7 +137,7 @@
         ></v-progress-circular>
       </div>
 
-      <div v-if="line_items.length > 0">
+      <div v-if="line_menu_items.length > 0">
         <j-plugin-section-header>Redshift from Centroid</j-plugin-section-header>
         <v-row>
           <j-docs-link>Assign the centroid reported above to the observed wavelength of a given line and set the resulting redshift.  Lines must be loaded and plotted through the Line Lists plugin first.</j-docs-link>

From d3c42164a6a4c42a40b96aff00e8bc669d385edf Mon Sep 17 00:00:00 2001
From: Ricky O'Steen <rosteen@stsci.edu>
Date: Wed, 24 Apr 2024 12:14:49 -0400
Subject: [PATCH 2/2] Update changelog

---
 CHANGES.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CHANGES.rst b/CHANGES.rst
index fb1b21f556..3fcf8d2efb 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -66,7 +66,7 @@ Other Changes and Additions
 
 - Bump required Python version to 3.10. [#2757]
 
-- Line menu in Redshift from Centroid section of Line Analysis now shows values in current units. [#2816]
+- Line menu in Redshift from Centroid section of Line Analysis now shows values in current units. [#2816, #2831]
 
 3.9.2 (unreleased)
 ==================