Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: [WIP] robyn builds failing for python v3.13 #1006

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

VishnuSanal
Copy link
Contributor

@VishnuSanal VishnuSanal commented Oct 29, 2024

Description

This PR fixes #

Summary

This PR does fix robyn builds failing for python v3.13

PR Checklist

Please ensure that:

  • The PR contains a descriptive title
  • The PR contains a descriptive summary of the changes
  • You build and test your changes before submitting a PR.
  • You have added relevant documentation
  • You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

notes to self:

  • build succeeds when building with PYO3_USE_ABI3_FORWARD_COMPATIBILITY=1 maturin develop
  • else, fails with the following error:
error: failed to run custom build command for `pyo3-ffi v0.20.3`

Caused by:
  process didn't exit successfully: `/home/vishnu/PycharmProjects/Robyn/target/debug/build/pyo3-ffi-0e37b8b8c00293fc/build-script-build` (exit status: 1)
  --- stdout
  cargo:rerun-if-env-changed=PYO3_CROSS
  cargo:rerun-if-env-changed=PYO3_CROSS_LIB_DIR
  cargo:rerun-if-env-changed=PYO3_CROSS_PYTHON_VERSION
  cargo:rerun-if-env-changed=PYO3_CROSS_PYTHON_IMPLEMENTATION
  cargo:rerun-if-env-changed=PYO3_PRINT_CONFIG
  cargo:rerun-if-env-changed=PYO3_USE_ABI3_FORWARD_COMPATIBILITY

  --- stderr
  error: the configured Python interpreter version (3.13) is newer than PyO3's maximum supported version (3.12)
  = help: please check if an updated version of PyO3 is available. Current version: 0.20.3
  = help: set PYO3_USE_ABI3_FORWARD_COMPATIBILITY=1 to suppress this check and build anyway using the stable ABI
warning: build failed, waiting for other jobs to finish...

references:

Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 4:29am

@dave42w
Copy link
Contributor

dave42w commented Oct 29, 2024

This is good to see! Thanks.

I wonder if more of the dependencies could be updated? For example jinja2 is now on 3.1.4 and we have 3.0.1

'watchdog == 4.0.1', now 5.0.3
'orjson == 3.9.15' now 3.10.10

All these still support at least python 3.9 (all but orjson still support 3.8)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants