Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rigorously check for HTTPS when handling secure cookies #12

Open
vilmibm opened this issue Sep 21, 2015 · 0 comments
Open

Rigorously check for HTTPS when handling secure cookies #12

vilmibm opened this issue Sep 21, 2015 · 0 comments

Comments

@vilmibm
Copy link

vilmibm commented Sep 21, 2015

Checking that the uri instance descends from URI::HTTPS is insufficient:

return false if secure? && !(URI::HTTPS === uri)

Instead, this needs to check the actual scheme of the uri instance (or something else more meaningful). Faraday, for example, uses a URI::HTTP instance with scheme set to https for its secure connections and as a result can't work with this library and secure cookies.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant