Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Transaction label disappeared #109

Open
urza opened this issue Apr 27, 2021 · 2 comments
Open

Transaction label disappeared #109

urza opened this issue Apr 27, 2021 · 2 comments
Labels
enhancement New feature or request high High priority

Comments

@urza
Copy link

urza commented Apr 27, 2021

I created a transaction with label, few days later that label is not there :(

I don't know how exactly it happened. The transaction was unconfirmed for more then week, it contained only one input and one output and meanwhile I recieved and sent other transactions from this and other wallets in sparrow. Sorry that I don't hove more concrete steps how to reproduce this.

@craigraw
Copy link
Collaborator

My guess is that the node you were connected to purged the transaction from it's mempool during the recent period of high congestion. This may have removed it from Sparrow too, and then when the congestion decreased the transaction was propagated again from nodes with a higher mempool limit. Sparrow would then have picked it up again sans the label.

There's a good argument to say that Sparrow should never drop transactions (once broadcast they are in effect permanent) but there is a reality of buggy server implementations and bad connections to consider as well. If Sparrow cannot remove transactions it cannot fix these issues.

The alternative is to store labels in some other place. I'll look into this.

@6102bitcoin 6102bitcoin added the enhancement New feature or request label May 20, 2021
@6102bitcoin
Copy link
Collaborator

6102bitcoin commented May 20, 2021

Outstanding Action: Store labels locally to avoid loosing a label.
Proposed Priority: High

@6102bitcoin 6102bitcoin added the high High priority label May 23, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request high High priority
Projects
None yet
Development

No branches or pull requests

3 participants