Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

tracking:play event never triggered #43

Open
bianchidotdev opened this issue Aug 27, 2024 · 1 comment
Open

tracking:play event never triggered #43

bianchidotdev opened this issue Aug 27, 2024 · 1 comment

Comments

@bianchidotdev
Copy link

Hey hey. I was just testing adding this plugin to my player and saw that I wasn't able to get a play (non-firstplay) event to fire. I think the trigger is just missing here. I may also be missing something though. Let me know - I can open a PR if you'd like.

if (!hasBeenTriggered) {
hasBeenTriggered = true;
this.trigger('tracking:firstplay', {
secondsToLoad: +(secondsToLoad.toFixed(3))
});
}

@spodlecki
Copy link
Owner

@bianchidotdev I only track the first time a user clicks "play," not every time the play button is pressed. This is because we're usually more interested in knowing whether the user chose to play the content at all, rather than counting every play action, which could include multiple pauses and plays. I found tracking every play event wasn't useful.

If you'd like to submit a pull request, can certainly add that event though. Please add to README if you do

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants