From 656920ea9a373fd762258a9671aa640dbbc638ec Mon Sep 17 00:00:00 2001
From: spoorn <spookump@gmail.com>
Date: Sat, 10 Dec 2022 10:59:54 -0800
Subject: [PATCH] clippy

---
 bench/src/lib.rs         | 2 +-
 durian/src/packet.rs     | 3 +++
 durian_macros/src/lib.rs | 6 +++++-
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/bench/src/lib.rs b/bench/src/lib.rs
index 14488ab..ac1b83f 100644
--- a/bench/src/lib.rs
+++ b/bench/src/lib.rs
@@ -92,7 +92,7 @@ pub fn setup(num_clients: u32, start_port: u32) -> (Vec<PacketManager>, PacketMa
     (client_managers, server_manager)
 }
 
-pub fn sync_example_multiclient_server(client_managers: &mut Vec<PacketManager>, server_manager: &mut PacketManager) {
+pub fn sync_example_multiclient_server(client_managers: &mut [PacketManager], server_manager: &mut PacketManager) {
     let server_addr = "127.0.0.1:5000";
 
     // broadcast packets to all recipients, and receive all packets from sender
diff --git a/durian/src/packet.rs b/durian/src/packet.rs
index 4420d9a..57eb1bb 100644
--- a/durian/src/packet.rs
+++ b/durian/src/packet.rs
@@ -1,3 +1,5 @@
+#![allow(clippy::type_complexity)]
+
 use std::any::{type_name, Any, TypeId};
 use std::error::Error;
 use std::fmt::Debug;
@@ -324,6 +326,7 @@ impl PacketManager {
     ///
     /// # Panic
     /// If the [`Runtime`] could not be created.  Usually happens if you call `new()` from an existing async runtime.
+    #[allow(clippy::new_without_default)]
     pub fn new() -> Self {
         let runtime = tokio::runtime::Builder::new_multi_thread().enable_all().build();
         match runtime {
diff --git a/durian_macros/src/lib.rs b/durian_macros/src/lib.rs
index f7f57ec..f5d60cb 100644
--- a/durian_macros/src/lib.rs
+++ b/durian_macros/src/lib.rs
@@ -79,6 +79,7 @@ pub fn bincode_packet(_attr: TokenStream, tokens: TokenStream) -> TokenStream {
                         panic!("Struct annotated with #[bincode_packet] and has named fields cannot have empty number of fields")
                     }
                     // See https://github.com/serde-rs/serde/issues/1465 for why serde macro is needed
+                    #[allow(clippy::needless_return)]
                     return quote! {
                         #[derive(durian::serde::Serialize, durian::serde::Deserialize, durian::BinPacket)]
                         #[serde(crate = "durian::serde")]
@@ -87,6 +88,7 @@ pub fn bincode_packet(_attr: TokenStream, tokens: TokenStream) -> TokenStream {
                     .into();
                 }
                 Fields::Unit => {
+                    #[allow(clippy::needless_return)]
                     return quote! {
                         #[derive(durian::UnitPacket)]
                         #input
@@ -139,6 +141,7 @@ pub fn bin_packet(tokens: TokenStream) -> TokenStream {
     let name = input.ident;
     let packet_builder_name = Ident::new((name.to_string() + "PacketBuilder").as_str(), Span::call_site());
 
+    #[allow(clippy::needless_return)]
     return quote! {
         impl durian::Packet for #name {
             fn as_bytes(&self) -> durian::bytes::Bytes {
@@ -192,6 +195,7 @@ pub fn unit_packet(tokens: TokenStream) -> TokenStream {
     let name_str = format!("\"{}\"", name);
     let packet_builder_name = Ident::new((name.to_string() + "PacketBuilder").as_str(), Span::call_site());
 
+    #[allow(clippy::needless_return)]
     return quote! {
         impl durian::Packet for #name {
             fn as_bytes(&self) -> durian::bytes::Bytes {
@@ -229,7 +233,7 @@ pub fn error_only_message(tokens: TokenStream) -> TokenStream {
 
     let mut has_message = false;
     for field in fields_punct.iter() {
-        if field.ident.as_ref().unwrap().to_string() == "message".to_string() {
+        if *field.ident.as_ref().unwrap() == *"message" {
             has_message = true;
             break;
         }