SFlux does not have apply(JFlux)

[zackman0010]

The SFlux class does not have an apply method that takes a JFlux. This means that, with the removal of the deprecated Flux, there is no longer a way to convert a JFlux to an SFlux.

[rs017991]

@zackman0010 the ScalaConverters class adds implicit asScala methods to JFlux and JMono, so you can do like:

import reactor.core.scala.publisher.ScalaConverters

JFlux.just("whatever").asScala

[sinwe]

Or another shortcut is
val sFlux = SFlux.fromPublisher(jFlux)

[zackman0010]

Thank you, I somehow missed that one when I was looking through SFlux last night.

[zackman0010]

@sinwe If I submitted a merge request to add another apply method to SFlux that simply calls the fromPublisher method, which is the same thing that SMono's apply does, would it be accepted?

[sinwe]

@zackman0010 You can try and raise PR. I'm not sure if that would be working because of below

object SFlux {
    def apply[T](elements: T*): SFlux[T] = SFlux.fromIterable(elements)
}

When you do SFlux(jFlux) it might be treated as an SFlux with elements on single JFlux instead of converting the JFlux to SFlux.
But I might be wrong. That's just on top of my head.

But it'd be nice if it works because that'll make it consistent with SMono(jMono)

[zackman0010]

You raised a good point, so I went to a scratch sheet to test it out. It looks like, if there's both a T* and a more specific apply function available, it will use the more specific one over the T* one. Not shown in this screenshot is the final test I did where I did not explicitly define the result type (val result5 = Result(testPublisher)). It still ran the Publisher apply method.

The test I added on #34 also passed successfully

[sinwe]

Thanks... I’ll merge your PR soon and I’ll cut a release soon as we’ve got couple of PRs merged to master

[sinwe]

Released on v0.4.6