Skip to content

Create an AbstractChatModel class that adds logging of request and response. #909

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
markpollack opened this issue Jun 20, 2024 · 2 comments
Closed

Create an AbstractChatModel class that adds logging of request and response. #909

markpollack opened this issue Jun 20, 2024 · 2 comments

Comments

@markpollack
Copy link
Member

markpollack commented Jun 20, 2024 •
edited
Loading

debug log level should be sufficient. This needs to occur in a few places, in particular in the case of Flux, see DefaultCallPromptResponseSpec.doGetChatResponse and DefaultStreamPromptResponseSpec.doGetFluxChatResponse for implementation hints.

Change OpenAiChatModel to inherit from this abstract base class. Once that is reviewed and discussed, we can have a separate PR that would change all the other implementations of ChatModel to extend AbstractChatModel
@markpollack markpollack added this to the 1.0.0-M2 milestone Jun 20, 2024
@markpollack markpollack changed the title Create a Logging Advisor that logs requests and responses Add logging into ChatClient to log request and response. Jun 20, 2024
@markpollack markpollack mentioned this issue Jun 20, 2024
Open
@markpollack markpollack changed the title Add logging into ChatClient to log request and response. Create an AbstractChatModel class that adds logging of request and response. Jun 20, 2024
@ThomasVitale
Copy link
Contributor

I shared a few thoughts about this in #512 (comment)

@markpollack
Copy link
Member Author

Closing in favor of #512

@markpollack markpollack removed this from the 1.0.0-M2 milestone Jul 23, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@markpollack @sobychacko @ThomasVitale