Skip to content

spring-boot-autoconfigure-processor incorrectly process @ConditionalOnClass with an inner class value #11282

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
jearton opened this issue Dec 7, 2017 · 1 comment
Closed

spring-boot-autoconfigure-processor incorrectly process @ConditionalOnClass with an inner class value #11282

jearton opened this issue Dec 7, 2017 · 1 comment
Assignees
@snicoll
Labels
type: bug A general bug
Milestone
1.5.10

Comments

@jearton
Copy link
Contributor

jearton commented Dec 7, 2017 •
edited by snicoll
Loading

Problem Detail:

I'm using Spring Boot 1.5.9.RELEASE. When spring-boot-autoconfigure-processor process @ConditionalOnClass with an inner class value, there is no dollar # the generated text of inner class.

Verify Steps:

  1. Clone this repository: https://github.com/jearton/spring-boot-autoconfigure-processor-issue.git

  2. Execute cd spring-boot-autoconfigure-processor-issue && ./mvnw clean compile

  3. View the file target/classes/META-INF/spring-autoconfigure-metadata.properties,
    you'll see the difference. First is dot, second is dollar. The second is correct.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 7, 2017
@jearton jearton changed the title spring-boot-autoconfigure-processor:1.5.9.RELEASE uncorrectly process @ConditionalOnClass with an inner class value spring-boot-autoconfigure-processor:1.5.9.RELEASE incorrectly process @ConditionalOnClass with an inner class value Dec 7, 2017
@snicoll snicoll added priority: normal type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 7, 2017
@snicoll snicoll added this to the 1.5.10 milestone Dec 7, 2017
@snicoll snicoll self-assigned this Dec 7, 2017
@snicoll snicoll changed the title spring-boot-autoconfigure-processor:1.5.9.RELEASE incorrectly process @ConditionalOnClass with an inner class value spring-boot-autoconfigure-processor incorrectly process @ConditionalOnClass with an inner class value Dec 7, 2017
@snicoll snicoll closed this as completed in 846e642 Dec 7, 2017
@snicoll
Copy link
Member

snicoll commented Dec 7, 2017

Thank you for the report and the sample, that's very useful!

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@snicoll snicoll

Labels
type: bug A general bug
Projects
None yet
Milestone
1.5.10
Development

No branches or pull requests
3 participants
@snicoll @jearton @spring-projects-issues