Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Micrometer tracing auto-configuration doesn't register all ObservationHandlers #31272

Closed
mhalbritter opened this issue Jun 8, 2022 · 1 comment
Assignees
Labels
type: bug A general bug
Milestone

Comments

@mhalbritter
Copy link
Contributor

It seems that the micrometer tracing auto-configuration doesn't register all ObservationHandlers at the ObservationRegistry.

ObservationRegistryPostProcessor runs, calls ObservationRegistryConfigurer#configure, which uses an ObjectProvider<ObservationHandler<Context>> to get all ObservationHandlers. This call only returns the bean from MicrometerTracingAutoConfiguration#defaultTracingObservationHandler, and not the ones from MicrometerTracingAutoConfiguration#httpServerTracingObservationHandler or MicrometerTracingAutoConfiguration#httpClientTracingObservationHandler.

@mhalbritter mhalbritter added the type: bug A general bug label Jun 8, 2022
@mhalbritter mhalbritter added this to the 3.0.0-M4 milestone Jun 8, 2022
@mhalbritter mhalbritter self-assigned this Jun 8, 2022
@mhalbritter mhalbritter modified the milestones: 3.0.0-M4, 3.0.x Jun 8, 2022
@mhalbritter
Copy link
Contributor Author

mhalbritter commented Jun 10, 2022

There's an ugly unchecked cast with a rawtype needed, this can be removed once Micrometer 1.10.0-M3 is released.

@mhalbritter mhalbritter modified the milestones: 3.0.x, 3.0.0-M4 Jun 10, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

1 participant