Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add resource hints for default templates location #31310

Closed
sdeleuze opened this issue Jun 9, 2022 · 2 comments
Closed

Add resource hints for default templates location #31310

sdeleuze opened this issue Jun 9, 2022 · 2 comments
Assignees
@snicoll
Labels
type: enhancement A general enhancement
Milestone
3.0.0-M4

Comments

@sdeleuze
Copy link
Contributor

sdeleuze commented Jun 9, 2022

Similar to #31278, it would be great to add resource hints for templates (if possible taking in account the configured value). Current regexp generated by Spring Native is "pattern": "^templates/.*".
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 9, 2022
@philwebb philwebb added the status: pending-design-work Needs design work before any code can be developed label Jun 9, 2022
@wilkinsona
Copy link
Member

This feels like something that the existing TemplateAvailabilityProvider implementations could help with. They're already loaded via spring.factories so using them at build time shouldn't cause any problems. Also, they already make use of the prefix and suffix application properties so they know where to look for templates.

@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 10, 2022
@wilkinsona wilkinsona added this to the 3.0.x milestone Jun 10, 2022
@wilkinsona wilkinsona changed the title Add resource hints for templates Automatically add resource hints for templates Jun 10, 2022
@philwebb philwebb mentioned this issue Jun 13, 2022
Closed
@snicoll snicoll self-assigned this Jun 15, 2022
@snicoll snicoll removed the status: pending-design-work Needs design work before any code can be developed label Jun 15, 2022
@snicoll
Copy link
Member

snicoll commented Jun 15, 2022

We've had a look to TemplateAvailabilityProvider and changing that is quite involved. For consistency with other issues that "just" register the defaut location, we're going to do the same here.

@snicoll snicoll modified the milestones: 3.0.x, 3.0.0-M4 Jun 15, 2022
@snicoll snicoll changed the title Automatically add resource hints for templates Add resource hints for default templates location Jul 18, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@snicoll snicoll

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.0.0-M4
Development

No branches or pull requests
5 participants
@sdeleuze @snicoll @philwebb @wilkinsona @spring-projects-issues