Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Revisit JPA Query Transformer design #2855

Closed
mp911de opened this issue Mar 14, 2023 · 1 comment
Closed

Revisit JPA Query Transformer design #2855

mp911de opened this issue Mar 14, 2023 · 1 comment
Labels
in: query-parser Everything related to parsing JPQL or SQL status: superseded An issue that has been superseded by another type: task A general task

Comments

@mp911de
Copy link
Member

mp911de commented Mar 14, 2023

The transformer design creates excessive array lists on each operation. While this seems appropriate for query rewrite (applying Sort, deriving a COUNT query), detecting projections, aliases, and constructor expressions follows the same scheme.

We should reuse the results from parsing/visting passes and reduce the amount of model visits.
@mp911de mp911de added type: task A general task in: query-parser Everything related to parsing JPQL or SQL labels Mar 14, 2023
@mp911de mp911de added the status: superseded An issue that has been superseded by another label Jan 31, 2025
@mp911de
Copy link
Member Author

mp911de commented Jan 31, 2025

Fixed via #3726 and #3309

@mp911de mp911de closed this as completed Jan 31, 2025
@mp911de mp911de closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
in: query-parser Everything related to parsing JPQL or SQL status: superseded An issue that has been superseded by another type: task A general task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mp911de