Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Issue/remove code duplication #1925

Closed
wants to merge 2 commits into from
Closed

Conversation

schauder
Copy link
Contributor

ONLY MERGE AFTER GA RELEASE

Mainly reimplements the changes undone in 49e343f.
The check for presence of the ID property is implemented for all variants for save, as it should.

See #1924

Mainly reimplements the changes undone in 49e343f.
The check for presence of the ID property is implemented for all variants for save, as it should.

See #1924
@schauder schauder requested a review from mp911de October 29, 2024 12:11
@mp911de mp911de added status: on-hold We cannot start working on this issue yet type: task A general task labels Oct 29, 2024
schauder added a commit that referenced this pull request Nov 18, 2024
Mainly reimplements the changes undone in 49e343f.
The check for presence of the ID property is implemented for all variants for save, as it should.

See #1924
Original pull request #1925
@schauder
Copy link
Contributor Author

Merged.

@schauder schauder closed this Nov 18, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
status: on-hold We cannot start working on this issue yet type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants