Wait for lenient bean creation in non-locked threads as well

Closes gh-34349
spring-projects · Feb 12, 2025 · dfc10c1 · dfc10c1
1 parent bbb593d
commit dfc10c1
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 17 deletions.
diff --git a/...src/main/java/org/springframework/beans/factory/support/DefaultSingletonBeanRegistry.java b/...src/main/java/org/springframework/beans/factory/support/DefaultSingletonBeanRegistry.java
@@ -303,26 +303,29 @@ public Object getSingleton(String beanName, ObjectFactory<?> singletonFactory) {
 					beforeSingletonCreation(beanName);
 				}
 				catch (BeanCurrentlyInCreationException ex) {
-					if (locked) {
-						this.lenientCreationLock.lock();
-						try {
-							while ((singletonObject = this.singletonObjects.get(beanName)) == null) {
-								if (!this.singletonsInLenientCreation.contains(beanName)) {
-									throw ex;
-								}
-								try {
-									this.lenientCreationFinished.await();
-								}
-								catch (InterruptedException ie) {
-									Thread.currentThread().interrupt();
-								}
+					this.lenientCreationLock.lock();
+					try {
+						while ((singletonObject = this.singletonObjects.get(beanName)) == null) {
+							if (!this.singletonsInLenientCreation.contains(beanName)) {
+								break;
+							}
+							try {
+								this.lenientCreationFinished.await();
+							}
+							catch (InterruptedException ie) {
+								Thread.currentThread().interrupt();
 							}
-							return singletonObject;
-						}
-						finally {
-							this.lenientCreationLock.unlock();
 						}
 					}
+					finally {
+						this.lenientCreationLock.unlock();
+					}
+					if (singletonObject != null) {
+						return singletonObject;
+					}
+					if (locked) {
+						throw ex;
+					}
 					// Try late locking for waiting on specific bean to be finished.
 					this.singletonLock.lock();
 					locked = true;

diff --git a/...ontext/src/test/java/org/springframework/context/annotation/BackgroundBootstrapTests.java b/...ontext/src/test/java/org/springframework/context/annotation/BackgroundBootstrapTests.java
@@ -102,6 +102,8 @@ static class UnmanagedThreadsBeanConfig {
 
 		@Bean
 		public TestBean testBean1(ObjectProvider<TestBean> testBean3, ObjectProvider<TestBean> testBean4) {
+			new Thread(testBean3::getObject).start();
+			new Thread(testBean4::getObject).start();
 			new Thread(testBean3::getObject).start();
 			new Thread(testBean4::getObject).start();
 			try {