Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Incorrect Java Syntax in Spring Framework Documentation [SPR-16811] #21351

Closed
spring-projects-issues opened this issue May 10, 2018 · 1 comment
Assignees
Labels
status: backported An issue that has been backported to maintenance branches type: documentation A documentation task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Sviatoslav Hryb opened SPR-16811 and commented

Section Data Access, paragraph 3.7.4. Handling complex types for stored procedure calls contains incorrect and not understandable fragments of Java code.

  1. One snippet of Java code doesn't contain a name of a variable of class TestItem (image1):
  2. Another snippet of code has several following problems: (image2).
  • doesn't contain a name of a variable of class TestItem
  • it is not perceivable why we need aforementioned variable
  • there is only an invocation of the method declareParameter without mentioned corresponding object of some class that invoke it.

Affects: 4.3.17, 5.0.6

Reference URL: https://docs.spring.io/spring/docs/5.0.6.RELEASE/spring-framework-reference/data-access.html#orm-general

Attachments:

Referenced from: commits 9d1789e, 2818051, 765d18e

Backported to: 4.3.18

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Good catch! I've revised those examples accordingly. declareParameter was meant to be used from within the constructor of a StoredProcedure subclass, similar to earlier examples.

@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches type: documentation A documentation task labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.0.7 milestone Jan 11, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
status: backported An issue that has been backported to maintenance branches type: documentation A documentation task
Projects
None yet
Development

No branches or pull requests

2 participants