Skip to content

Update reference documentation with a link to "GraphQL Server" Getting Started Guide #551

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
dondonz opened this issue Dec 1, 2022 · 15 comments
Assignees
Labels
type: documentation A documentation task
Milestone

Comments

@dondonz
Copy link

dondonz commented Dec 1, 2022

Hello, I'm wondering what the process is for adding a Spring for GraphQL guide to https://spring.io/guides?

Is it possible to add a link to the graphql-java Spring for GraphQL tutorial https://www.graphql-java.com/tutorials/getting-started-with-spring-boot? Or I can help write a new tutorial.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 1, 2022
@bclozel bclozel added the for: team-attention An issue we need to discuss as a team to make progress label Dec 1, 2022
@bclozel
Copy link
Member

bclozel commented Dec 1, 2022

Hello @dondonz, this tutorial looks nice thanks for writing it!
We're indeed considering one or more guides on spring.io, but didn't start yet. We can discuss and organize in this issue.

What did you have in mind for a new guide on spring.io - something very similar to the graphql-java.com one or would you like to use another angle?

We can link to the graphql-java.com tutorial from our reference documentation, project page or another spring.io/guide. I'm not sure the infrastructure would allow us to add a new guide entry that would link to graphql-java.com though.

@bclozel bclozel added status: waiting-for-feedback We need additional information before we can continue and removed for: team-attention An issue we need to discuss as a team to make progress labels Dec 1, 2022
@dondonz
Copy link
Author

dondonz commented Dec 2, 2022

Ok great, I'm keen to help write guides! I'm happy to work with you on ideas, it could be a quick start guide like the graphql-java.com one, or could be more detailed. Did you & the team have any ideas in mind?

This idea came from my colleague, who was trying out Spring for GraphQL for the first time. One of the first places he visited for more info was spring.io/guide.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Dec 2, 2022
@rstoyanchev
Copy link
Contributor

I think a getting-started guide under https://spring.io/guides#getting-started-guides, similar to the one you have created is an obvious first step. It might be possible to add a test with GraphQlTester as well.

@dondonz
Copy link
Author

dondonz commented Dec 4, 2022

Good idea to add tests.

We're getting ready to release graphql-java v20 at the moment. After that's done I'll come back to writing this guide

@rstoyanchev
Copy link
Contributor

Thanks, this is the repository for the GSG guides.

@bclozel
Copy link
Member

bclozel commented Dec 7, 2022

@rstoyanchev we'll need to request the creation of a new repository in the org, as getting-started-guides is merely the template that @dondonz can use to start with (but should not submit a PR to).

What should be the name of the repository? "spring-guides/gs-graphql-server"? "spring-guides/gs-graphql-server-mvc"? At first, when we create the repo we should drop the "gs-" prefix as otherwise this will publish it instantly.

@rstoyanchev
Copy link
Contributor

"spring-guides/gs-graphql-server" sounds good.

@dondonz
Copy link
Author

dondonz commented Dec 8, 2022

Thanks @bclozel for setting up the repo!

@bclozel
Copy link
Member

bclozel commented Dec 8, 2022

You can start a PR on and we can iterate on it with you!
https://github.com/spring-guides/graphql-server

Let's continue there - we'll keep this issue opened until the guide is properly published.

@dondonz
Copy link
Author

dondonz commented Dec 16, 2022

Thanks!!

@dondonz
Copy link
Author

dondonz commented Dec 31, 2022

Could you please add me to the repo? I don't have push permissions at the moment.

Or alternatively I can create a PR via a fork. If you'd prefer to use forks, could you please commit an empty README.adoc file to enable forking?

@rstoyanchev
Copy link
Contributor

I've added a README.

@dondonz
Copy link
Author

dondonz commented Jan 8, 2023

Thanks!

As an update I've been working on the guide this weekend, I'll put up a PR when I'm done with the first proper draft.

@dondonz
Copy link
Author

dondonz commented Jan 15, 2023

Here's my first draft - feel free to comment and edit as you like. More in PR description: spring-guides/gs-graphql-server#1

@rstoyanchev
Copy link
Contributor

I've left initial feedback on the PR. Let's continue the discussion there. I'll re-purpose this issue as a documentation update to link to the guide from our reference docs.

@rstoyanchev rstoyanchev changed the title Adding a GraphQL guide to https://spring.io/guides LAdding a GraphQL guide to https://spring.io/guides Jan 19, 2023
@rstoyanchev rstoyanchev changed the title LAdding a GraphQL guide to https://spring.io/guides Update reference documentation with a link to "GraphQL Server" Getting Started Guide guide Jan 19, 2023
@rstoyanchev rstoyanchev added type: documentation A documentation task and removed status: feedback-provided Feedback has been provided status: waiting-for-triage An issue we've not yet triaged labels Jan 19, 2023
@rstoyanchev rstoyanchev added this to the 1.2 Backlog milestone Jan 19, 2023
@rstoyanchev rstoyanchev changed the title Update reference documentation with a link to "GraphQL Server" Getting Started Guide guide Update reference documentation with a link to "GraphQL Server" Getting Started Guide Jan 19, 2023
@rstoyanchev rstoyanchev self-assigned this Feb 1, 2023
@rstoyanchev rstoyanchev removed this from the 1.2 Backlog milestone Feb 1, 2023
@rstoyanchev rstoyanchev modified the milestones: 1.2.0-M1, 1.1.2 Feb 1, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type: documentation A documentation task
Projects
None yet
Development

No branches or pull requests

4 participants