Skip to content

Exposing the Kafka Yammer metrics to Spring Boot Actuator #127

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
dmachlin opened this issue Jun 23, 2016 · 6 comments
Closed

Exposing the Kafka Yammer metrics to Spring Boot Actuator #127

dmachlin opened this issue Jun 23, 2016 · 6 comments

Comments

@dmachlin
Copy link

Hi,
It would be great to automatically expose all of Kafka's metrics to Spring's metrics via spring boot actuator.
Do you know of a project that enables this?
If this isn't possible out-of-the-box, do you think it would be a good addition to this project?

@artembilan
Copy link
Member

We really are going to implement Spring Boot auto-configuration in the next 1.1 version.
I think this Kafka Yammer metrics would be a good addition into Boot Actuator as well.

We are not sure yet when the solution will have place: in this project directly or in the next Spring Boot 1.5 iteration, but we definitely will come back to the nice "Convention on Configuration" universe.

@stepio
Copy link
Contributor

stepio commented Jul 2, 2016

Hi,

I've published my implementation of this here:
https://github.com/stepio/spring-actuator-kafka
Short description is also provided. I've already integrated this into my project - looks good as of now.

@artembilan @garyrussell
Again, I'm not sure that it's wise to keep this project separately. So I'd like to merge it to spring-kafka or spring-boot - what do you think?

@artembilan
Copy link
Member

Hello, @stepio !

Thank you for letting to know! That's great to have such a good progress 😄 .

Well, for now I don't have a proper answer for you, if it may move to Spring Boot...
I'd be fine to merge your cool work into Spring Kafka directly, but we really should decide here in our team what would be better.

@garyrussell is on PTO until the next week and we still don't have the proper scope for the next 1.1 iteration.

So, stay tuned!

@stepio
Copy link
Contributor

stepio commented Jul 5, 2016

I agree that it's not clear where to merge it as of now, so I'll just keep tracking this issue.

Meanwhile I'll also take a look on Spring Boot's /health endpoint - seems that some support for Kafka will be desirable there as well.

@garyrussell
Copy link
Contributor

We're adding Kafka support to boot 1.5

spring-projects/spring-boot#6961

So this probably belongs over there after that is merged.

@garyrussell
Copy link
Contributor

Boot autoconfigures Kafka metrics (since 2.1) here.

@artembilan artembilan removed this from the Waiting For Triage milestone Dec 7, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

4 participants