Skip to content

syntax highlighting for embedded languages (SpEL, JPQL, SQL, HQL, etc.) inside of Java editor (in Eclipse) #1235

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
martinlippert opened this issue Apr 18, 2024 · 5 comments

Comments

@martinlippert
Copy link
Member

martinlippert commented Apr 18, 2024

Support for syntax highlighting for SpEL, JPQL, SQL, HQL, etc. in Eclipse when working in the standard Java editor. The current implementation uses the semantic token support of the LSP, which works in Eclipse only if used inside the Generic Editor (the standard LSP based editor in Eclipse).

This issue is to support this mechanism for the Java editor in Eclipse as well.

@BoykoAlex
Copy link
Contributor

POC is working which is a great thing of course :-) but we are still miles away from the final solution:

Screenshot 2024-08-14 at 17 46 16

@martinlippert
Copy link
Member Author

In order to implement this, we need a number of changes in JDT UI itself, therefore moving the target milestone to 4.27.0, which will be the release based on Eclipse 2024-12 - which is the earliest target for those changes in JDT UI.

@martinlippert
Copy link
Member Author

The groundwork for this in JDT UI moves towards the 2025-03 release of Eclipse, so our target milestone to the corresponding 4.29.0 release in March 2025.

@martinlippert
Copy link
Member Author

We need to wait for the corresponding changes in LSP4E here, so we need to move this out to the 4.30.0 release to finally have all the upstream changes around to enable this in the Spring Tools.

@BoykoAlex
Copy link
Contributor

The lsp4e part for it (eclipse-lsp4e/lsp4e#1161) is merged. Marking as fixed.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants