Skip to content

create more precise range for implicit web annotation names validation #1411

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
martinlippert opened this issue Nov 18, 2024 · 0 comments
Closed
Assignees
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: validation type: enhancement

Comments

@martinlippert
Copy link
Member

The validation that marks unnecessary name attributes in certain web annotations (like @RequestParam or @PathVariable) underlines the whole annotation section of the code at the moment, creating the impression that the full annotation statement is not necessary, whereas the attribute about the name is the only piece of the annotation that could be removed.

Instead of marking the complete annotation statement, the validation should only mark the name attribute definition.

Example

public Owner findOwner(@PathVariable(name = "ownerId", required = false) Integer ownerId) {
                       |-----------------------------------------------|

whereas the marker should only be positioned below the name = "ownerId":

public Owner findOwner(@PathVariable(name = "ownerId", required = false) Integer ownerId) {
                                     |--------------|
@martinlippert martinlippert added type: enhancement for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: validation labels Nov 18, 2024
@martinlippert martinlippert added this to the Backlog milestone Nov 18, 2024
@martinlippert martinlippert modified the milestones: Backlog, 4.27.0.RELEASE Nov 18, 2024
@martinlippert martinlippert self-assigned this Nov 18, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: validation type: enhancement
Projects
None yet
Development

No branches or pull requests

1 participant