Skip to content

vscode-concourse: support both .yml and .yaml files #838

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

bmalehorn
Copy link
Contributor

Some people write .yml, some write .yaml. Both pipeline.yml and pipeline.yaml behave the same way, so highlight them both as Concourse pipelines & tasks.

Added because my organization uses pipeline.yaml consistently, so probably other people do too.

Reproduction

  1. create a file ~/tmp/pipeline.yaml
  2. run extension
  3. open terminal
  4. code ~/tmp/pipeline.yaml
  5. look at the bottom to see if it says "Concourse Pipeline" or "YAML"
before after
image image

@pivotal-cla
Copy link

@bmalehorn Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@bmalehorn Thank you for signing the Contributor License Agreement!

@martinlippert martinlippert merged commit 3111e86 into spring-projects:main Sep 9, 2022
@martinlippert
Copy link
Member

Thanks a lot @bmalehorn for the contribution, much appreciated!!!

@kdvolder Please take a second look here and commit additional changes if you think we need anything else here.

@martinlippert martinlippert added this to the 4.16.0.RELEASE milestone Sep 9, 2022
@bmalehorn bmalehorn deleted the vscode-concourse-support-yaml branch September 9, 2022 17:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants