Skip to content

[refactoring] open rewrite refactoring menu item is broken when no language server is running #865

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
martinlippert opened this issue Nov 4, 2022 · 3 comments
Assignees
Labels
for: eclipse something that is specific for Eclipse theme: refactoring type: bug

Comments

@martinlippert
Copy link
Member

The menu item to select and run OpenRewrite recipes is broken and throws exceptions if there is no language server around. We should probably start a language server in case there is no language server running when selecting the menu item or executing a recipe from the dialog.

@martinlippert martinlippert added type: bug for: eclipse something that is specific for Eclipse theme: refactoring labels Nov 4, 2022
@martinlippert martinlippert added this to the 4.17.0.RELEASE milestone Nov 4, 2022
@BoykoAlex
Copy link
Contributor

I think the only solution is whatever we come up for #880

@BoykoAlex
Copy link
Contributor

BoykoAlex commented Nov 11, 2022

It should have worked in the case of VSCode. This commit should address this issue for VSCode: 5b5ac91

As for the Eclipse, I don't think there is anything in LSP4E to start LS on an action execution... Therefore i think our best bet is the solution to #880.

@BoykoAlex
Copy link
Contributor

Should be fixed with dd2f60a

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
for: eclipse something that is specific for Eclipse theme: refactoring type: bug
Projects
None yet
Development

No branches or pull requests

2 participants