Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[performance] switch cache implementation to fastjson #1289

Closed
martinlippert opened this issue Jul 9, 2024 · 2 comments
Closed

[performance] switch cache implementation to fastjson #1289

martinlippert opened this issue Jul 9, 2024 · 2 comments

Comments

@martinlippert
Copy link
Member

At the moment, the IndexCacheOnDisc implementation uses Gson to convert objects to and from JSON. Especially the write operations are executed quite frequently (basically every time a file changes and the cache is updated), switching the JSON conversion part over to fastjson will improve performance.

Side note: with this switch, we would also need to update the custom type adapters that we implemented for Gson to the corresponding mechanism in fastjson.

@martinlippert
Copy link
Member Author

Additional cache-related performance improvements are captured in #1071

@martinlippert martinlippert removed this from the 4.28.0.RELEASE milestone Dec 30, 2024
@martinlippert
Copy link
Member Author

Due to #1071 being implemented now, the impact of improving the pure speed of the JSON serialization of the symbols/diagnostics cache is not big enough to prioritize this issue at the moment. Closing as declined.

@martinlippert martinlippert closed this as not planned Won't fix, can't repro, duplicate, stale Dec 30, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant