Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Avoid fetching too large block range #20

Closed
mpetrun5 opened this issue Mar 22, 2024 · 0 comments · Fixed by #21
Closed

Avoid fetching too large block range #20

mpetrun5 opened this issue Mar 22, 2024 · 0 comments · Fixed by #21
Labels
QA Issue requires QA validation

Comments

@mpetrun5
Copy link
Contributor

mpetrun5 commented Mar 22, 2024 •
edited
Loading

Prevent prover trying to fetch more than 1000 blocks to avoid RPC issues where those requests are blocked.

Implementation details

Fetch logs with multiple requests when a block range is too large.

Testing details

  • unit tests
  • QA

Acceptance Criteria

  • when there hasn't been a step for a large range of blocks (current RPC limit is 5000) the prover should still be able to submit all the executions from that range
@mpetrun5 mpetrun5 changed the title Avoid fetching too large of a block range Avoid fetching too large block range Mar 22, 2024
@mpetrun5 mpetrun5 added the QA Issue requires QA validation label Apr 4, 2024
@mpetrun5 mpetrun5 mentioned this issue Apr 4, 2024
Merged
9 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
QA Issue requires QA validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: prevent fetching large block range sprintertech/sygma-inclusion-prover
1 participant
@mpetrun5