Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Synchronous did:key resolver #425

Open
vdods opened this issue Apr 19, 2022 · 1 comment
Open

Synchronous did:key resolver #425

vdods opened this issue Apr 19, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@vdods
Copy link
Contributor

vdods commented Apr 19, 2022

I'd like to suggest that DIDKey could be made into a synchronous DID resolver, since that particular resolver doesn't have any need for async.

This could either simply factoring the body of the DIDKey::resolve method out into a impl DIDKey pub fn resolve_sync, or more formally by making a DIDResolverSynchronous trait, have DIDKey implement that, and add (into ssi/src/did_resolve.rs) an automatically derived impl of DIDResolver for anything impl'ing DIDResolverSynchronous.

Thoughts?

@clehner clehner added the enhancement New feature or request label Apr 21, 2022
@TheButlah
Copy link

TheButlah commented Aug 19, 2023

Random person looking for a simple and correct did:key implementation here: Having an async trait for something purely in-memory and synchronous is overcomplicating it. Would be cool if did-method-key had an inherent impl for resolution and made the resolver trait feature gated, for those of us only interested in that particular method.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants