Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support options passed to plugin when using template_string #35

Closed
sqlalchemy-bot opened this issue Apr 6, 2007 · 6 comments
Closed
Labels
bug Something isn't working low priority runtime

Comments

@sqlalchemy-bot
Copy link

Migrated issue, originally created by Anonymous

TGPlugin currently doesn't pass options passed to the constructor when instantiating a Template from a template_string. Attached patch fixes it

Alberto


Attachments: options_when_tpl_string.diff

@sqlalchemy-bot
Copy link
Author

Michael Bayer (@zzzeek) wrote:

[changeset:253]

@sqlalchemy-bot
Copy link
Author

Changes by Michael Bayer (@zzzeek):

  • changed status to closed

@sqlalchemy-bot
Copy link
Author

Anonymous wrote:

Unfortunately, this fix breaks this [http://docs.pythonweb.org/display/pylonscookbook/An+Alternative+ToscaWidgets+Setup+with+Mako ToscaWidgets recipe] because the middleware passes "mako.directories" as part of tmpl_options, and Template.init no longer takes a "directories" keyword. However, TemplateLookup does, so the change needs to keep passing "directories" to TemplateLookup, but not to Template.init.

@sqlalchemy-bot
Copy link
Author

Changes by Anonymous:

  • changed status to reopened

@sqlalchemy-bot
Copy link
Author

Michael Bayer (@zzzeek) wrote:

[changeset:293]

@sqlalchemy-bot
Copy link
Author

Changes by Michael Bayer (@zzzeek):

  • changed status to closed

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working low priority runtime
Projects
None yet
Development

No branches or pull requests

1 participant