Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

package.json specifies pnpm >=9, which affects dependent packages #22

Closed
jakebailey opened this issue Jun 24, 2024 · 0 comments · Fixed by #23
Closed

package.json specifies pnpm >=9, which affects dependent packages #22

jakebailey opened this issue Jun 24, 2024 · 0 comments · Fixed by #23
Labels
bug Something isn't working

Comments

@jakebailey
Copy link
Contributor

jakebailey commented Jun 24, 2024

The package.json of this package has an engines field of pnpm >=9.

This actually declares to package managers "users installing this package with pnpm in their projects must be using pnpm >=9". As such, attempting to install this package in a pnpm v8 repo from the npm registry gives:

Your pnpm version is incompatible with "registry.npmjs.org/smol-toml/1.2.1".

Expected version: >= 9
Got: 8.10.4

This is happening because the package's manifest has an engines.pnpm field specified.
To fix this issue, install the required pnpm version globally.

To install the latest version of pnpm, run "pnpm i -g pnpm".

I don't think the intent of this field in this repo was to prevent installation of this package with pnpm 8, but rather to declare that this repo in particular is using pnpm v9.

Can this engine restriction be removed, and maybe replaced with some other kind of pnpm pinning, e.g. the packageManager field if desired?

@cyyynthia cyyynthia added the bug Something isn't working label Jun 25, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants