Refactor: TransactionConnection::run_contract_call has too many arguments

[kantai]

The function

fn run_contract_call<F>(
        &mut self,
        sender: &PrincipalData,
        sponsor: Option<&PrincipalData>,
        contract: &QualifiedContractIdentifier,
        public_function: &str,
        args: &[Value],
        abort_call_back: F,
        max_execution_time: Option<std::time::Duration>,
    ) -> Result<(Value, AssetMap, Vec<StacksTransactionEvent>), Error>

Trips clippy due to too many arguments, and indeed, it's too many arguments, and its the kind of thing that also triggers large multi-file changesets whenever the signature gets updated. This is annoying.

My suggestion for this (and similarly BlockBuilder::try_mine_tx_with_len) is to make an argument struct:

pub struct RunContractCallArg<'a, F> {
    sender: &'a PrincipalData,
    sponsor: Option<&'a PrincipalData>,
    ..
}

And then we can define constructors and chaining modifiers to simplify our lives:

/// Setup arguments for running a contract call with no abort callback
///  and default options
fn new(sender, sponsor, contract, fn_name, args) -> Self {
   Self { sender, sponsor, contract, fn_name, args, abort_call_back: |_| false, ... }
}
fn with_time_limt(mut self, time_limit: Duration) -> Self {
   self.time_limit = Some(time_limit);
   self
}

[rdeioris]

I did a first round with run_contract_call. I think that if we want to pursue this logic we first need a macro allowing automatic generation of the with_ functions. In addition to this, by looking at the resulting code, it looks like the with_ calls are not inlined. We should probably enforce this (even if the two currently involved functions are not called so often in the run loop)