Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SRC721R Recursive collections #437

Open
DerpHerpenstein opened this issue Oct 16, 2024 · 1 comment
Open

SRC721R Recursive collections #437

DerpHerpenstein opened this issue Oct 16, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@DerpHerpenstein
Copy link

DerpHerpenstein commented Oct 16, 2024

https://github.com/DerpHerpenstein/src-721/tree/draft_version_r

TLDR:
SRC721 looks like this: {"p":"src-721","op":"mint","c":"A9286823293586848000","ts":[3,3,3,0,4,2,0]}

SRC721R looks like this
op return: STAMP:721|c:A0123456789123456789|op:mint
olga data: <script src=/s/A12389842328028445000 id=1234></script>

The op return contains the 721 designation, the mint of and the collection reference and the olga data contains the ts reference in the src (the trait is a js file for a generative collection instead of an image file).
This way all the same information as the original stc721 is present in the tx for easy indexing.

@reinamora137
Copy link
Collaborator

reinamora137 commented Oct 16, 2024

how is the 'collection name' stored in the SRC-721R deploy? That's the main part that needs to be added to the indexer so we can drop all the mints into the collection table properly.

Also perhaps identify the SRC721-R deploy so it displays a placeholder image rather than the broken ones. like in this deploy transaction: https://stampchain.io/stamps/dbe23d8623963a433a9c455416c2af1cbb11274d182b5166ffad95582c9a308f.svg

The other item it would be nice to flag them as SRC-721R in the ident field to go along with the other 'sub' protocols ( SRC-721,SRC-20,SRC-101). this will make querying for both collection name and 'recursive' collections easy on the frontend

EDIT: - oh i guess there isn't a differentiation with the SRC721 vs 721R deployment structure it's just the usual json with the collection name there. was confusing looking at it from the deploy image side. will need to update that so it uses a placeholder image as well on the deploy. Have to get this in queue.

@reinamora137 reinamora137 self-assigned this Oct 16, 2024
@reinamora137 reinamora137 added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Oct 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants