Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Exception handling in tests is inconsistent. #10

Open
jacob-meacham opened this issue Feb 12, 2017 · 0 comments
Open

Exception handling in tests is inconsistent. #10

jacob-meacham opened this issue Feb 12, 2017 · 0 comments
Labels

Comments

@jacob-meacham
Copy link

I ran into this while debugging #9.

The connection exception, which gives valuable information, is silently swallowed in testers.py#Tester#get_connection. In contrast, tester exceptions themselves aren't caught at all and cause mongoaudit to crash.

Expected behavior:
The connection exception is surfaced and testing does not continue
If an exception is encountered in a particular test, it is logged and the rest of the tests continue as normal. This allows a user to see the results of the non-crashed tests.

@aesedepece aesedepece added the bug label Feb 13, 2017
@aesedepece aesedepece modified the milestone: 0.0.2 Feb 13, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants