Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Block property name changed in websocket RPC methods #245

Closed
FabijanC opened this issue Nov 8, 2024 · 1 comment
Closed

Block property name changed in websocket RPC methods #245

FabijanC opened this issue Nov 8, 2024 · 1 comment

Comments

@FabijanC
Copy link
Contributor

FabijanC commented Nov 8, 2024

Not sure, but I think all other methods that require a block ID input do so with a parameter called block_id. And in ws methods in v0.8.0-rc.0 the name used is block:

https://github.com/starkware-libs/starknet-specs/blob/v0.8.0-rc0/api/starknet_ws_api.json#L15

Can we rename this to block_id? For the sake of consistency and perhaps reusability of implementation structures.

@FabijanC
Copy link
Contributor Author

Closed via #246

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant