Make some global variables constant #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 79.13% 79.27% +0.13%
==========================================
Files 6 6
Lines 580 579 -1
==========================================
Hits 459 459
+ Misses 121 120 -1
Continue to review full report at Codecov.
|
|
@staticfloat Would it be alright, for this repository, for us to allow Buildkite to run on PRs from forks? |
giordano
commented
Jan 26, 2022
| @@ -89,16 +89,15 @@ function select_executor(verbose::Bool) | |||
| error("Could not find any available executors for $(triplet(HostPlatform()))!") | |||
| end | |||
|
|
|||
| _preferred_executor = nothing | |||
| const _preferred_executor = Ref{Union{Nothing, (x->Type{x}).(all_executors)...}}(nothing) | |||
There was a problem hiding this comment.
Not sure this helps anything in practice, all_executors has already three elements, with more possibly to come.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no way to check whether I broke something, tests are already broken for me (#77).