Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[UI - Wallet Stability] Rename NetworkSelector component to RouterPanel and analyse if some improvements needed #15209

Closed
Tracked by #14711
noeliaSD opened this issue Jun 17, 2024 · 5 comments
Assignees
Labels
E:D Wallet SendModal Stabilize, improve and sync with expected design and functionality refactor ui-stability-phase-candidate wallet-team
Milestone

Comments

@noeliaSD
Copy link
Contributor

noeliaSD commented Jun 17, 2024

Design

Design 2

Screenshot 2024-06-17 at 15 30 47

Screenshot 2024-06-17 at 15 30 29

  • Rename NetworkSelector component to RouterPanel (or more appropriate name).
  • Quick analysis if there are some dependences or easy api cleanups we can do now.
  • Maybe create some subtasks for next improvements setps.

Notes:

  • There will be a new design of the Transactions Card in the next milestones so probably it does'n make sense to put a lot of effort now
  • There will be the new router V2 that probably will need some additional information to be displayed but also effort for the next milestone.
@noeliaSD noeliaSD added ui-team refactor E:D Wallet SendModal Stabilize, improve and sync with expected design and functionality labels Jun 17, 2024
@noeliaSD noeliaSD added this to the 2.30.0 Beta milestone Jun 17, 2024
@noeliaSD noeliaSD changed the title Rename NetworkSelector component to RouterPanel (or more appropriate name) and analyse if some improvements needed fo this milestone Rename NetworkSelector component to RouterPanel (or more appropriate name) and analyse if some improvements needed Jun 17, 2024
@noeliaSD noeliaSD changed the title Rename NetworkSelector component to RouterPanel (or more appropriate name) and analyse if some improvements needed [UI - Wallet Stability] Rename NetworkSelector component to RouterPanel and analyse if some improvements needed Jun 17, 2024
@noeliaSD
Copy link
Contributor Author

There's an improvement to add for this milestone for the fees panel inside the RouterPanel component. Here the task: #14208

@noeliaSD noeliaSD assigned noeliaSD and unassigned micieslak Jun 21, 2024
@noeliaSD noeliaSD moved this to Next iteration in Status Desktop/Mobile Board Jun 21, 2024
@noeliaSD noeliaSD moved this to Next iteration in Status Desktop/Mobile Board Jul 1, 2024
@noeliaSD noeliaSD moved this from Next iteration to Iteration Backlog in Status Desktop/Mobile Board Jul 1, 2024
@noeliaSD noeliaSD moved this from Iteration Backlog to In Progress in Status Desktop/Mobile Board Jul 8, 2024
@noeliaSD
Copy link
Contributor Author

Take into account his comment here: #15216 (comment)

@noeliaSD
Copy link
Contributor Author

noeliaSD commented Jul 17, 2024

Created draft PR with the major part of the refactor but since there's no capacity to work on the qml tests for each small component neither adding them to storybook, it doesn't add a lot of value to the release 2.30, without the small components testing.

It's moved to next milestone. During stability phase we will work on components testing and then integrating the already done work into the app.

@noeliaSD
Copy link
Contributor Author

noeliaSD commented Aug 1, 2024

@micieslak there's a draft pr created and missing things are:

  • Add the following components to Storybook and create qml tests for each one:
    • NetworkCardsComponent
    • NetworksSimpleRoutingView
    • NetworksAdvancedCustomRoutingView
    • FeesView

@alexjba
Copy link
Contributor

alexjba commented Aug 21, 2024

The SendModal will go through a re-design

@alexjba alexjba closed this as completed Aug 21, 2024
@github-project-automation github-project-automation bot moved this from Next iteration to Done in Status Desktop/Mobile Board Aug 21, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
E:D Wallet SendModal Stabilize, improve and sync with expected design and functionality refactor ui-stability-phase-candidate wallet-team
Projects
Archived in project
4 participants