Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use same functions for regular and keycard accounts #1743

Closed
yenda opened this issue Dec 18, 2019 · 0 comments
Closed

Use same functions for regular and keycard accounts #1743

yenda opened this issue Dec 18, 2019 · 0 comments

Comments

@yenda
Copy link
Contributor

yenda commented Dec 18, 2019

Problem

We already had multiple bugs caused by the fact that keycard uses the same functions as a regular accounts but duplicated and with simple changes. Sometimes the regular account functions have been updated and the keycard ones have been forgotten.

We should use the same functions with some basic conditions, in order to achieve that one solution would be to pass a struct as one of the arguments which would contain the chat HexKey for keycard so that we can branch on it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants