-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Can't push branch and create tag at the same time #145
Comments
Thanks for reporting! As you said, the tag is created: grouparoo/app-examples@1ede8b3 I wonder if this is related to this message GitHub displays :
Maybe it's related that the workflow was triggered by I will try to come up with a failing test for our test suite to ensure that we can reproduce this. |
Thanks! Here's what I'm doing in the interum grouparoo/app-examples#124 |
@evantahler Can confirm that the pushed commits are not correct. Will push a PR with tests and a solution shortly. Would then be great if you could test those changes in your project, to make sure it really works as expected. |
@evantahler I've opened a PR with a fix in #146 You can use it by updating your workflow like this: - - uses: stefanzweifel/git-auto-commit-action@v4
+ - uses: stefanzweifel/git-auto-commit-action@fixes/145
with:
commit_message: Updating Packages
commit_user_name: Grouparoo Bot
commit_user_email: hello@grouparoo.com
commit_author: Grouparoo Bot <hello@grouparoo.com>
branch: ${{ github.head_ref }}
tagging_message: v${{ env.CORE_VERSION }} I will do some additional tests in my own projects. If everything goes well, I will tag a new version next week. |
Thanks for checking this out so quickly! It works! I gave it a try: Produced this commit grouparoo/app-examples@8f4c57d and the tag https://github.com/grouparoo/app-example/releases/tag/v0.2.3 |
I will close this issue now. Thanks again for reporting! |
Thank you! |
Huh... https://github.com/grouparoo/app-example/actions/runs/622211253 Unable to resolve action |
@evantahler Can you try it with |
OH! I forgot the |
Version of the Action
v4
(@v4
)Describe the bug
Reading the docs, I would expect the following to both push any changes back to the branch AND tag that commit with
env.CORE_VERSION
. However, what is happening is that the tag is created but the branch is not updated.Action: https://github.com/grouparoo/app-example/blob/master/.github/workflows/update.yml
Run: https://github.com/grouparoo/app-example/runs/1983284335?check_suite_focus=true
Specifcally:
Expected behavior
I would expect both the branch to be pushed with the latest code & the tag to be created.
The text was updated successfully, but these errors were encountered: