Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove v20-dependent dead code in overlay/herder #4588

Open
marta-lokhova opened this issue Dec 19, 2024 · 0 comments
Open

Remove v20-dependent dead code in overlay/herder #4588

marta-lokhova opened this issue Dec 19, 2024 · 0 comments
Labels

Comments

@marta-lokhova
Copy link
Contributor

There are several v20 checks in overlay/herder/tx queue. Now that the network is way past v20, all that code can be cleaned up. For example, we don't need to wait to externalize to initialize soroban tx queue (it doesn't need to be a pointer anymore). We should search for protocolVersionStartsFrom(protocolVersion, SOROBAN_PROTOCOL_VERSION) and remove dead code where appropriate.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant