Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Post parallel ledger close cleanup #4592

Open
5 tasks
Tracked by #4318
marta-lokhova opened this issue Dec 19, 2024 · 0 comments
Open
5 tasks
Tracked by #4318

Post parallel ledger close cleanup #4592

marta-lokhova opened this issue Dec 19, 2024 · 0 comments
Assignees
Labels
cleanup refactoring or other internal improvements

Comments

@marta-lokhova
Copy link
Contributor

marta-lokhova commented Dec 19, 2024

To do after #4543 is landed (opening a separate issue to reduce the scope of this PR as per discussion with @graydon):

  • Audit gRandomEngine multi-threaded access
  • Rename CatchupManager -> ApplyExternalizedLedgersManager
  • Remove app from BucketManager/FutureBucket or at a minimum enforce no access to LedgerManager from BucketManager (to guarantee no deadlocks)
  • Enforce that only one thread can reference an active LedgerTxn at all times
  • Remove LM from valueExternalized flow in Herder. Herder should go directly to LedgerApplyManager, since it is the module that handles applying now.

This will also resolve #4318

@marta-lokhova marta-lokhova added the cleanup refactoring or other internal improvements label Dec 19, 2024
@marta-lokhova marta-lokhova self-assigned this Dec 19, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cleanup refactoring or other internal improvements
Projects
None yet
Development

No branches or pull requests

1 participant