Skip to content
This repository has been archived by the owner on Mar 14, 2019. It is now read-only.

Affects html output #17

Open
ArmorDarks opened this issue Aug 16, 2017 · 1 comment
Open

Affects html output #17

ArmorDarks opened this issue Aug 16, 2017 · 1 comment

Comments

@ArmorDarks
Copy link

It seems that plugin affects html output far beyond just adding srcsets.

For instance, it changes HTML quotes:

<div class='test'></div>

to

<div class="test"></div>

Also, it affects inner whitespacing:

<div               class="test"></div>

becomes

<div class="test"></div>

While issue with whitespace doesn't seem to be serious (though, it make Git comparison show a lot of unintended changes), changes of quotes actually is a serious issue, because it will break following case:

<div data-settings='{"id":9089}'></div>

Result will be

<div data-settings="{"id":9089}"></div>

which effectively makes HTML wrong.

@ArmorDarks
Copy link
Author

As expected, this is cheerio issue: cheeriojs/cheerio#1006

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant