Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feature request: Extend preview.win_options to override win_options #509

Open
1 task done
windowsrefund opened this issue Nov 3, 2024 · 2 comments
Open
1 task done
Labels
enhancement New feature or request

Comments

@windowsrefund
Copy link

Did you check existing requests?

  • I have searched the existing issues

Describe the feature

I now see how win_options extends to the preview window. This is good since I like to have things like number, signcolumn, and relativenumber enabled for various reasons. However, I don't need these things in the preview window (all I want to do is preview the content in the most lightweight manner possible). If preview.win_options could be refactored to override the higher level win_options, one could disable all the bloat when it comes to previewing.

Provide background

No response

What is the significance of this feature?

nice to have

Additional details

No response

@windowsrefund windowsrefund added the enhancement New feature or request label Nov 3, 2024
@stevearc
Copy link
Owner

stevearc commented Nov 3, 2024

I'm not really sure what you're talking about. The preview window only sets window options from preview.win_options

for k, v in pairs(config.preview.win_options) do
vim.api.nvim_set_option_value(k, v, { scope = "local", win = winid })
end

@stevearc stevearc added the question Further information is requested label Nov 3, 2024
@windowsrefund
Copy link
Author

This doesn't appear to be working

          preview = {
            win_options = {
              number = false,
              relativenumber = false,
              signcolumn = "no",
            },
          },

@github-actions github-actions bot removed the question Further information is requested label Nov 4, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants