Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

In GSEA fixed bug on download image and updated labels requested by GDC #2868

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

airenzp
Copy link
Collaborator

@airenzp airenzp commented Feb 22, 2025

Description

Fix on the the image downloaded from the burguer menu icon, it is updated every time a table row is selected but it needs to be cleared on main to avoid downloading a wrong image (jira-sv-2571) .

Checklist

Check each task that has been performed or verified to be not applicable.

  • Tests: added and/or passed unit and integration tests, or N/A
  • Todos: commented or documented, or N/A
  • Notable Changes: updated release.txt, prefixed a commit message with "fix:" or "feat:", added to an internal tracking document, or N/A

@@ -185,6 +185,7 @@ class gsea {
async main() {
this.config = structuredClone(this.state.config)
this.settings = this.config.settings.gsea
this.imageUrl = null // Reset the image URL
Copy link
Member

@siosonel siosonel Feb 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should implement this as part of opts.downloadHandler() that's passed to download icon? Maybe more reliable that way, can detect what tab/view is visible or downloadable.

Otherwise, should create a key to hold all instance props that will be cleared in main(), to make it easier to track/remember, and may be able to automate this later as part of rx dispatch cycle (so the deletion would not have to be remembered to be done by each component).

   this.clearedProps = {.}
  
 main() {
    ...
    for(const k of Object.keys(this.clearedProps)) delete this.clearedProps[k]
    ..
 }
 
 // in other functions, can set arbitrary props under this.clearedProps

Copy link
Collaborator Author

@airenzp airenzp Feb 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not my plot. I just added the minimum fixes I needed to solve the jira ticket. As these are improvements I suggest we talk about them when you are back and we include Robin in the conversation? I am not sure I follow you completely. Also I dont want to take more time from you and I would rather minimize changes prone to errors as I am not familiar with the GSEA logic.

@airenzp airenzp force-pushed the v2.108.0-jira-sv2568-2569-fix branch from 628b20f to b16372d Compare February 25, 2025 17:10
@airenzp airenzp changed the title In GSEA reset image url on main to avoid downloading a previous image (jira-sv-2571) In GSEA fixed bug on download image and updated labels requested by GDC Feb 25, 2025
@airenzp airenzp force-pushed the v2.108.0-jira-sv2568-2569-fix branch from b16372d to 29d24b7 Compare February 25, 2025 17:12
@xzhou82 xzhou82 merged commit c0b96ee into release-2.108.0 Feb 27, 2025
3 checks passed
@xzhou82 xzhou82 deleted the v2.108.0-jira-sv2568-2569-fix branch February 27, 2025 17:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants