Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

In GSEA fixed bug on download image and updated labels requested by GDC #2868

Merged
merged 1 commit into from
Feb 27, 2025
Merged

In GSEA fixed bug on download image and updated labels requested by GDC #2868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions client/plots/gsea.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ class gsea {
async main() {
this.config = structuredClone(this.state.config)
this.settings = this.config.settings.gsea
this.imageUrl = null // Reset the image URL
Copy link
Member

@siosonel siosonel Feb 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should implement this as part of opts.downloadHandler() that's passed to download icon? Maybe more reliable that way, can detect what tab/view is visible or downloadable.

Otherwise, should create a key to hold all instance props that will be cleared in main(), to make it easier to track/remember, and may be able to automate this later as part of rx dispatch cycle (so the deletion would not have to be remembered to be done by each component).

   this.clearedProps = {.}
  
 main() {
    ...
    for(const k of Object.keys(this.clearedProps)) delete this.clearedProps[k]
    ..
 }
 
 // in other functions, can set arbitrary props under this.clearedProps

Copy link
Collaborator Author

@airenzp airenzp Feb 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not my plot. I just added the minimum fixes I needed to solve the jira ticket. As these are improvements I suggest we talk about them when you are back and we include Robin in the conversation? I am not sure I follow you completely. Also I dont want to take more time from you and I would rather minimize changes prone to errors as I am not familiar with the GSEA logic.

await this.setControls()
if (this.dom.header)
this.dom.header.html(
Expand Down
4 changes: 2 additions & 2 deletions client/plots/singleCellPlot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ class singleCellPlot {
if (q.singleCell?.DEgenes) {
const label = this.dom.deDiv
.append('label')
.html('View DE genes for cells of a cluster versus rest of the cells: ')
.html('View differentially expressed genes for cells of a cluster versus rest of the cells: ')
this.dom.deselect = label.append('select').on('change', e => {
const display = this.dom.deselect.node().value ? 'inline-block' : 'none'
const cluster = this.dom.deselect.node().value.split(' ')[1]
Expand Down Expand Up @@ -722,7 +722,7 @@ class singleCellPlot {
if (this.app.opts.genome.termdbs) {
// assumption is that can run gsea on the differential genes, when the genome-level termdb is available (which is right now geneset dbs)
tabs.push({
label: 'Gene Set Enrichment Analysis',
label: 'Gene Set Enrichment Analysis(GSEA)',
id: DE_GSEA_TAB,
active: false,
callback: () => showActiveDETab(DE_GSEA_TAB)
Expand Down
4 changes: 3 additions & 1 deletion release.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@

Fix
- Updated labels requested on [JIRA] (FEAT-857)
- Fixed bug in the download image in GSEA