Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Handle server URL comparison correctly #84

Open
4 tasks
karol-maciaszek opened this issue Mar 9, 2020 · 1 comment
Open
4 tasks

Handle server URL comparison correctly #84

karol-maciaszek opened this issue Mar 9, 2020 · 1 comment
Labels

Comments

@karol-maciaszek
Copy link
Contributor

Chore summary
IHttpOperation merger does not handle all the cases for comparison of server URLs.

Tasks

  • host should be compared as case-insensitive
  • path should be compared as case-sensitive
  • variable names should be compared as case-sensitive (@philsturgeon is that correct assumption?)
  • the case, when a variable is a part of hostname, should be handled correctly: host can be compared case-insensitive while variable name should be compared case-sensitively

Additional context
This task is a followup for a discussion here: #83 (comment)

@philsturgeon
Copy link
Contributor

I don't have enough context to know if variable names should be case sensitive or not, I don't think it matters too much either way? Some people will expect it to work one way and others another.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants