Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

RFE: Take filesystem type in account into Block.HintAuto calculation #1094

Open
tbzatek opened this issue Apr 28, 2023 · 0 comments
Open

RFE: Take filesystem type in account into Block.HintAuto calculation #1094

tbzatek opened this issue Apr 28, 2023 · 0 comments

Comments

@tbzatek
Copy link
Member

tbzatek commented Apr 28, 2023

The Block.HintAuto property is an indication that the block device can be trusted for automounting - taking in account connection bus, block device type (floppies), devicemapper layering and corresponding fstab records.

Since this property is already used for clients (gvfs) to decide about automounting, adding their policy into the mix, it might be a good idea to take filesystem type in account as well. See also https://gitlab.gnome.org/GNOME/gvfs/-/blob/master/monitor/udisks2/gvfsudisks2volume.c#L414

This will ultimately need a list of trusted filesystem types defined somewhere, i.e. the Manager.SupportedFilesystems might not be sufficient (or comfortable for desktop users). Perhaps use the udiskslinuxfilesystem.c:well_known_filesystems list instead.

The goal is to further reduce attack vector by excluding ancient, unmantained or misc. kernel filesystem drivers.

Cc: @ondrejholy

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant