Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Implement app_v2 wiring #13

Open
fmorency opened this issue Jul 16, 2024 · 1 comment · May be fixed by #14
Open

Implement app_v2 wiring #13

fmorency opened this issue Jul 16, 2024 · 1 comment · May be fixed by #14

Comments

@fmorency
Copy link
Contributor

Using app_v1 is causing the TestAppImportExport simulation to fail in CosmosSDK v0.50.6.

I see similar behavior in this application.

KV stores are different: 27 key/value pairs in store A and 0 key/value pairs in store B
    sim_test.go:202: 
                Error Trace:    /home/fmorency/dev/tokenfactory/app/sim_test.go:202
                Error:          Not equal: 
                                expected: 27
                                actual  : 0
                Test:           TestAppImportExport
                Messages:       unequal sets of key-values to compare upgrade

The issue doesn't occur when using app_v2 wiring in CosmosSDK. Implement app_v2 wiring in this application and see if it fixes the problem.
@fmorency fmorency mentioned this issue Jul 16, 2024
Open
3 tasks
@fmorency fmorency changed the title Implement v2 app wiring Implement app_v2 wiring Jul 16, 2024
@fmorency
Copy link
Contributor Author

It appears that this module depends on wasm which depends on ibc. Both wasm and ibc are incompatible with v2 wiring.

See CosmWasm/wasmd#1286 and cosmos/ibc-go#3560

@fmorency fmorency linked a pull request Jul 17, 2024 that will close this issue
Draft
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(app): v2 wiring fmorency/tokenfactory
1 participant
@fmorency