Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

onChange doesn't work #595

Open
andreymal opened this issue Jun 3, 2022 · 1 comment
Open

onChange doesn't work #595

andreymal opened this issue Jun 3, 2022 · 1 comment

Comments

@andreymal
Copy link

I tried to use dist/luminous.min.js (commit 1c53f53) and found that onChange doesn't work:

new LuminousGallery(
  document.querySelectorAll('.gallery-item a'),
  {onChange: ({ imgEl }) => alert('This alert will never be triggered')},
);

But this code works:

new LuminousGallery(
  document.querySelectorAll('.gallery-item a'),
  {M: ({ j }) => alert('It works WHAT THE HECK!!!11')},
);

The minification minified things that shouldn't have been minified, lol

@sherwinski
Copy link
Contributor

Hey @andreymal thanks for bringing this to our attention. I've made a note of this and will ask one of our engineers to investigate.

@luqven luqven added the hacktoberfest Good first issue for hacktober contributors label Sep 28, 2022
@luqven luqven removed the hacktoberfest Good first issue for hacktober contributors label Nov 10, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants