feat(cmd): support wal cmd truncate command
#530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattisonchao
requested review from
merlimat,
coderzc and
RobertIndie
as code owners
merlimat
reviewed
Sep 24, 2024
cmd/wal/truncate/cmd.go
Outdated
Comment on lines
44
to
46
| Cmd.Flags().Int64Var(&options.shard, "shard", 0, "shard id") | ||
| Cmd.Flags().StringVar(&options.namespace, "namespace", "default", "namespace name") | ||
| Cmd.Flags().StringVar(&options.walDir, "wal-dir", "", "directory path") |
There was a problem hiding this comment.
These should be options of the wal command, so they get inherited by all subcommands
cmd/wal/truncate/cmd.go
Outdated
| Cmd.Flags().StringVar(&options.walDir, "wal-dir", "", "directory path") | ||
| // operations | ||
| Cmd.Flags().Int64Var(&options.safePointEntry, "safe-point-entry", math.MaxInt64, "the last safe entry offset") | ||
| Cmd.Flags().BoolVar(&options.lastEntry, "last-entry", false, "if trim the last entry") |
There was a problem hiding this comment.
Maybe rename into
Suggested change
| Cmd.Flags().BoolVar(&options.lastEntry, "last-entry", false, "if trim the last entry") | |
| Cmd.Flags().BoolVar(&options.lastEntry, "trim-last-entry", false, "trim the last entry from the wal") |
There was a problem hiding this comment.
Refined the usage and changed the prefix to truncate.
merlimat
approved these changes
Sep 25, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Introduce the wal cmd
truncatecommand to truncate corrupted unsynced data in the write-ahead log before implementing a CRC-based write-ahead log.