Skip to content
This repository has been archived by the owner on Apr 1, 2024. It is now read-only.

ISSUE-17137: PIP-200: Package Pulsar Trino distro and config in a dedicated folder #4749

Open
sijie opened this issue Aug 17, 2022 · 0 comments
Labels

Comments

@sijie
Copy link
Member

sijie commented Aug 17, 2022

Original Issue: apache#17137


Mailing list thread: https://lists.apache.org/thread/s985ypf0r0hzcm0mx653n5h2rt7n273v

Motivation

After apache#16683 merged, we upgrade PrestoSQL dependency in Pulsar SQL to the first several Trino version. To handle the name change cases and gradually refactor Pulsar SQL as a self-contained module so that we can move it into a standalone repository, I find that there're three major issues to resolve.

  1. Configs of Pulsar SQL go under the conf/ folder and mix with other Pulsar configs.
  2. Pulsar Docker images (base and all) bundle Pulsar SQL.
  3. Integration tests of Pulsar SQL are tightly coupled with the main repo (test infra).

This proposal is aimed at resolving the first issue to package Pulsar Trino distro and config in a dedicated folder; that is, to make it self-contained.

Goal

I have already prepared a draft to perform the changes as apache#17062. Generally, we move the config files under PRESTO_HOME and correspondingly update scripts.

In this way, all Trino distro artifacts are under the same home path, so that we can later move it out as a whole.

This change should not affect those who use Pulsar with the entry point script, but it changes the layout of the release artifact, so I'd prefer to perform a PIP process.

API Changes

N/A

Implementation

It's straightforward to inline in the "Goal" section.

However, the name of the folder (presto or trino) and the level of the folder (lib/presto/ or trino/) is open to discussion. I think both are fine and will try trino/ first.

To minimize unnecessary changes, I tend to keep the modules name pulsar-presto-xxx as is.

Alternatives

I don't make a completed proposal to resolve all three issues listed above. Because I'm still unfamiliar with the latter two topics yet and I'd prefer to implement these improvements one by one since they're naturally independent. If I try to make a completed proposal at once, it's highly possible I give up halfway.

Anything else?

Previous discussion:

@sijie sijie added the PIP label Aug 17, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant