Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Readonly setting does nothing #5716

Closed
streetwriters bot opened this issue May 20, 2024 · 3 comments
Closed

Readonly setting does nothing #5716

streetwriters bot opened this issue May 20, 2024 · 3 comments
Labels
good first issue Platform: Desktop Platform: Web Status: Confirmed Bug is confirmed but work on a fix hasn't yet started. Status: Investigating We are investigating the bug.

Comments

@streetwriters
Copy link

streetwriters bot commented May 20, 2024

Supersedes #5706

Readonly only works when the notes aren't locked. If a note is locked, the note is editable even in readonly mode.

Device information:
App version: 3.0.6-10be577-desktop
OS: OS X 10.15.7
Browser: Electron 29.3.1
Pro: true

@ammarahm-ed ammarahm-ed added Platform: Web Platform: Desktop Status: Investigating We are investigating the bug. Status: Confirmed Bug is confirmed but work on a fix hasn't yet started. good first issue labels May 21, 2024
@uniqueeest
Copy link
Contributor

uniqueeest commented May 21, 2024

hello @ammarahm-ed! I'm interested in this issue. Can I assign it?

@Kavit-Patel
Copy link

I forked the project and set it up locally. After creating an account on Notesnook in my local environment, when I tried to lock my note, it prompted me to "please upgrade your account to pro to use this feature".
20240521_17521972

@uniqueeest
Copy link
Contributor

uniqueeest commented May 21, 2024

@Kavit-Patel you should need to disabled "isPro" in lock.
and I already upload PR #5731. Please check it out and share if there's a better way!

@thecodrr thecodrr closed this as completed Jul 5, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
good first issue Platform: Desktop Platform: Web Status: Confirmed Bug is confirmed but work on a fix hasn't yet started. Status: Investigating We are investigating the bug.
Projects
None yet
Development

No branches or pull requests

4 participants