Using if else instead of switch and pulling out the commone one

stretchr · Dec 29, 2017 · a7101ec · a7101ec
1 parent 936f63d
commit a7101ec
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/.gitignore b/.gitignore
@@ -22,3 +22,4 @@ _testmain.go
 *.exe
 
 .DS_Store
+*.swp
diff --git a/mock/mock.go b/mock/mock.go
@@ -317,19 +317,12 @@ func (m *Mock) MethodCalled(methodName string, arguments ...interface{}) Argumen
 		}
 	}
 
-	//TODO: could simplify this
-	switch {
-	case call.Repeatability == 1:
+	if call.Repeatability == 1 {
 		call.Repeatability = -1
-		call.totalCalls++
-
-	case call.Repeatability > 1:
+	} else if call.Repeatability > 1 {
 		call.Repeatability--
-		call.totalCalls++
-
-	case call.Repeatability == 0:
-		call.totalCalls++
 	}
+	call.totalCalls++
 
 	// add the call
 	m.Calls = append(m.Calls, *newCall(m, methodName, arguments...))