Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

sl-blip makes strongloop projects unusable with safestart / package ver validators #1659

Closed
STRML opened this issue Sep 9, 2015 · 5 comments
Assignees

Comments

@STRML
Copy link
Member

STRML commented Sep 9, 2015

I've made an issue before about what I believe to be an abusive use of npm's optionalDependencies via sl-blip: #1079

This is also preventing package version validation modules like safestart from being used with strongloop projects.

For example:

/srv/api/node_modules/safestart/index.js:88
    throw error
          ^
Error: loopback-connector-remote dependency mismatch: sl-blip from /srv/api/node_modules/loopback/node_modules/sl-blip (expected: http://blip.strongloop.com/loopback-connector-remote@1.0.3, got: http://blip.strongloop.com/loopback@2.22.0)
    at fail (/srv/api/node_modules/safestart/index.js:83:17)
    at /srv/api/node_modules/safestart/index.js:73:17
    at Array.forEach (native)
    at scanDependencies (/srv/api/node_modules/safestart/index.js:47:38)
    at checkPath (/srv/api/node_modules/safestart/index.js:40:5)
    at /srv/api/node_modules/safestart/index.js:54:26
    at Array.forEach (native)
    at scanDependencies (/srv/api/node_modules/safestart/index.js:47:38)
    at checkPath (/srv/api/node_modules/safestart/index.js:39:5)
    at /srv/api/node_modules/safestart/index.js:54:26

Please remove blip.

@rmg
Copy link
Member

rmg commented Sep 11, 2015

This appears to be a combination of npm bugs that safestart is shining a light on :-(

There's also a very minor bug in safestart in that it is identifying these URLs as git URLs, though that could just be an unfortunate choice in variable naming :-)

@richardpringle
Copy link
Contributor

@rmg, this isn't a "loopback-core" issue is it? In other words, should this be closed and moved to another repo?

@richardpringle richardpringle self-assigned this Dec 8, 2015
@STRML
Copy link
Member Author

STRML commented Dec 8, 2015

@richardpringle Perhaps you can get someone from strongloop to comment on #1079 and consider removing sl-blip instead of surreptitiously tracking users?

@richardpringle
Copy link
Contributor

Hey @STRML, I'm going through the issues and doing some bug fixes on some of the loopback code so I just want to make sure the right person is looking at this.
Just trying to help.

@STRML
Copy link
Member Author

STRML commented Dec 8, 2015

Thanks @richardpringle -- appreciate it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

5 participants